-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#38: Added LocalToolCommandlet for Python #1073
#38: Added LocalToolCommandlet for Python #1073
Conversation
- added help properties for Python
Pull Request Test Coverage Report for Build 13656278073Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally in intellij with python --help
. Ready for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julia-cap thanks for implementing Python 👍
Did you read the story and also check the old implementation?
https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/scripts/command/python#L26-L54
cli/src/main/java/com/devonfw/tools/ide/tool/python/Python.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jörg Hohwiller <[email protected]>
@hohwille, yes, I checked the old story and had a look at the old implementation. Though I am not 100% sure why you are referring to the old implementation since with the ToolCommandlet we are using the URLs repository and the provided binaries. |
Hi @hohwille, I have only just noticed line 63 in old pip script and I am wondering if we should add this check to the Python ToolCommandlet and install if necessary? |
Today it was agreed, that such installation should be covered by the AWS tool and not by pip or Python. A test case will be executed to verify correct behavior, see PR for pip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julia-cap thanks for your update. Now everything is great and ready to merge. Awesome job👍
For the record:
@julia-cap thanks for implementing Python 👍 Did you read the story and also check the old implementation? https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/scripts/command/python#L26-L54
@hohwille, yes, I checked the old story and had a look at the old implementation. Though I am not 100% sure why you are referring to the old implementation since with the ToolCommandlet we are using the URLs repository and the provided binaries.
The latest version of Python seems to be 3.13.2 and that indeed has URLs for all OS:
https://github.com/devonfw/ide-urls/tree/master/python/python/3.13.2
This is really great. In order versions this was not the case. Check e.g.:
- https://github.com/devonfw/ide-urls/tree/master/python/python/3.9.21
- https://github.com/devonfw/ide-urls/tree/master/python/python/3.3.6
So let us look forward: New versions of python seem to support all OS now and we finally get what we wanted to archive. It may not work with older versions on some OS but python 2.x can already been considered kind of dead and 3.x versions can simply be upgraded to more recent versions supporting all OS.
Fixes #38
Implements: