Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38: Added LocalToolCommandlet for Python #1073

Conversation

julia-cap
Copy link
Contributor

@julia-cap julia-cap commented Feb 24, 2025

Fixes #38

Implements:

  • New LocalToolCommandlet Python which sets IgnoreSoftwareRepo to true
  • Added property for Python to help.properties and help_de.properties
  • Added entry to CHANGELOG

- added help properties for Python
@coveralls
Copy link
Collaborator

coveralls commented Feb 24, 2025

Pull Request Test Coverage Report for Build 13656278073

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 68.253%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 9 88.52%
Totals Coverage Status
Change from base Build 13656095330: 0.002%
Covered Lines: 7870
Relevant Lines: 11082

💛 - Coveralls

@julia-cap julia-cap self-assigned this Feb 24, 2025
@julia-cap julia-cap added enhancement New feature or request commandlet python runtime for python language labels Feb 24, 2025
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally in intellij with python --help. Ready for review.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julia-cap thanks for implementing Python 👍
Did you read the story and also check the old implementation?
https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/scripts/command/python#L26-L54

@julia-cap
Copy link
Contributor Author

@julia-cap thanks for implementing Python 👍 Did you read the story and also check the old implementation? https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/scripts/command/python#L26-L54

@hohwille, yes, I checked the old story and had a look at the old implementation. Though I am not 100% sure why you are referring to the old implementation since with the ToolCommandlet we are using the URLs repository and the provided binaries.

@julia-cap
Copy link
Contributor Author

Hi @hohwille, I have only just noticed line 63 in old pip script and I am wondering if we should add this check to the Python ToolCommandlet and install if necessary?

@julia-cap
Copy link
Contributor Author

Hi @hohwille, I have only just noticed line 63 in old pip script and I am wondering if we should add this check to the Python ToolCommandlet and install if necessary?

Today it was agreed, that such installation should be covered by the AWS tool and not by pip or Python. A test case will be executed to verify correct behavior, see PR for pip.

@hohwille hohwille added this to the release:2025.03.001 milestone Mar 4, 2025
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julia-cap thanks for your update. Now everything is great and ready to merge. Awesome job👍

For the record:

@julia-cap thanks for implementing Python 👍 Did you read the story and also check the old implementation? https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/scripts/command/python#L26-L54

@hohwille, yes, I checked the old story and had a look at the old implementation. Though I am not 100% sure why you are referring to the old implementation since with the ToolCommandlet we are using the URLs repository and the provided binaries.

The latest version of Python seems to be 3.13.2 and that indeed has URLs for all OS:
https://github.com/devonfw/ide-urls/tree/master/python/python/3.13.2

This is really great. In order versions this was not the case. Check e.g.:

So let us look forward: New versions of python seem to support all OS now and we finally get what we wanted to archive. It may not work with older versions on some OS but python 2.x can already been considered kind of dead and 3.x versions can simply be upgraded to more recent versions supporting all OS.

@hohwille hohwille merged commit 1bbdb83 into devonfw:main Mar 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commandlet enhancement New feature or request python runtime for python language
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Python
4 participants