Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1087: Fix MSI Build Job in GitHub Workflows #1088

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

alfeilex
Copy link
Member

Fixes: #1087

This PR fixes the missing include of ideasy.exe in the MSI build process for the nightly build and for the release workflow.

@alfeilex alfeilex self-assigned this Feb 27, 2025
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thank you so much for the lightning fast fix 👍

@hohwille hohwille added this to the release:2025.02.002 milestone Feb 27, 2025
@hohwille hohwille self-assigned this Feb 27, 2025
@hohwille hohwille merged commit cc6e45c into devonfw:main Feb 27, 2025
2 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13565547385

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.255%

Totals Coverage Status
Change from base Build 13565037741: 0.0%
Covered Lines: 7867
Relevant Lines: 11077

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add MSI Build Workflow Step to include ideasy.exe
3 participants