#910 Can not update intellij on linux #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Added LinkOption.NOFOLLOW_LINKS to verify if the symlink file itself exists or not - and not the target file/folder
…tion - Added LinkOption.NOFOLLOW_LINKS to verify if the symlink file itself exists or not - and not the target file/folder
mbilda
added
bugfix
update
Pull Request Test Coverage Report for Build 13669668814Details
💛 - Coveralls |
jan-vcapgemini
approved these changes
Mar 3, 2025
…tion - Removed exists() function from fileAccess because its just calling "super" - Adjusted usages of fileAccess.exists()
…on-linux' into fix/910-can-not-update-intellij-on-linux
jan-vcapgemini
approved these changes
Mar 4, 2025
…tion - Added entry to CHANGELOG.adoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #910
This PR fixes the issue if an simlink is broken and we check the file existence or want to delete the file.
If we wanna know if a file exists we wanna check the actual file itself and not the target where the simlink points to. That means if we wanna delete the actual file we shouldn't follow the simlink. Window automatically prevents that and always checks the file itself. Linux is a little bit "smarter" and knows that its a simlink file and automatically follows the link to the target file and checks if the target file exists. This is actually problematic, because we delete the simlink file and create a new one we a new target to update the versions.
LinkOption.NOFOLLOW_LINKS prevents both systems to follow the link in the simlink file and actually checks if the file itself exists.
This PR also reverts some changes from: #1078
As @hohwille suggested in an old PR:
#1078 (comment)
That the FileAcessImpl exists function doesn't really bring value to this i have decided to delete the method again.
That means we do not have to take care about some different behaviour because of the wrapper class where we may have a different implementation than using the usual Files.exists() function. The NOFOLLOW_LINKS option is set to the necessary places where we want to check the actual file and not the target of the simlink.