Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#102: implement update & create commandlet #150

Merged
merged 176 commits into from
Apr 8, 2024
Merged

#102: implement update & create commandlet #150

merged 176 commits into from
Apr 8, 2024

Conversation

salimbouch
Copy link
Contributor

@salimbouch salimbouch commented Nov 28, 2023 •
edited
Loading

closes #102
closes #101

@salimbouch
added class RepositoryCommandlet and its help function
e9d574f
@salimbouch
implemented run method when project is given as argument
76eba65
@salimbouch
implemented loadProperties
0e16de6
@salimbouch
added record RepositoryConfig, implemented run method, implemented lo…
69835e3 
…adProperties
@salimbouch
implemented build functionality, import missing
90145a6
@salimbouch
minor improvements
c738a0e
@salimbouch
javadoc
c3de09e
@salimbouch
fixed bug: tool installed but not found
c0fbd26
@salimbouch
Merge branch 'main' into 100-implement-repository-commandlet
89061ae
@salimbouch
created class UpdateCommandlet, implemented updateSettings method
edc7b1d
@salimbouch
created class UpdateCommandlet, implemented updateSettings method
7b43974
@salimbouch
Merge branch '100-implement-repository-commandlet' into 102-implement…
3fc8c23 
…-update-commandlet

# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java
@salimbouch
implemented repository update
15bdb62
@salimbouch
solved bug in CustomToolRepositoryImpl, created class CustomToolComma…
8063580 
…ndlet
@salimbouch
removed useless improt
1c729ae
@salimbouch
implemented install/update of custom tools
60e72bc
@salimbouch
minor change
01cb2b9
@salimbouch
Update RepositoryCommandlet.java
db8008a
@salimbouch
Merge branch '100-implement-repository-commandlet' into 102-implement…
ec96f35 
…-update-commandlet
@salimbouch
made variable constant
a64b959
@salimbouch
added the help function
6f265e1
@salimbouch salimbouch marked this pull request as ready for review November 28, 2023 23:10
@salimbouch salimbouch self-assigned this Nov 28, 2023
@tobka777 tobka777 requested a review from aBega2000 November 30, 2023 09:36
@tobka777 tobka777 assigned aBega2000 and unassigned salimbouch Nov 30, 2023
aBega2000
aBega2000 reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@aBega2000 aBega2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions about naming of two variables and the setting of a variable

@aBega2000 aBega2000 assigned salimbouch and unassigned aBega2000 Nov 30, 2023
hohwille
hohwille requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salimbouch thanks for your rework and great that you merged implementation of #101 and #102 into this single PR what makes it a lot easier. 👍
I left various review comments for improvement or fixes. Also we need to have a test for CreateCommandlet as I can only see that UpdateCommandlet is tested so far.
As this PR has quite some complexity and we have done some review rounds already, could you create a teams meeting for Thursday or Friday so we can align and complete the last steps together to get this to the finishing line and avoid further review ping-pongs?
You have already done a very great job and this is close to the end but it will make things much easier, if we discuss face-to-face.

salimbouch and others added 20 commits April 3, 2024 18:11
@salimbouch
Merge branch 'main' into 102-implement-update-commandlet
f7a307c
@salimbouch @hohwille
Update cli/src/main/java/com/devonfw/tools/ide/commandlet/CreateComma…
9569abb 
…ndlet.java

Co-authored-by: Jörg Hohwiller <[email protected]>
@salimbouch @hohwille
Update cli/src/main/java/com/devonfw/tools/ide/commandlet/CreateComma…
15b4f30 
…ndlet.java

Co-authored-by: Jörg Hohwiller <[email protected]>
@salimbouch @hohwille
Update cli/src/main/java/com/devonfw/tools/ide/commandlet/CreateComma…
caf0a1e 
…ndlet.java

Co-authored-by: Jörg Hohwiller <[email protected]>
@salimbouch
removed useless files
9d4ef31
@salimbouch
suggested imporvements
0471e07
@salimbouch
new super class for create and update
7cee5ff
@salimbouch
renamed class
27761ce
@salimbouch
Update CreateCommandlet.java
94b3d47
@salimbouch
EOL problems
b7af107
@salimbouch
Update UpdateCommandlet.java
b2d425a
@salimbouch
Fix EOL
2e7b523
@salimbouch
Fix EOL Diff
26169f4
@salimbouch
junit test for CreateCommandlet
c86e93c
@salimbouch
changes in meeting
ba37c7d
@salimbouch
added javadoc to setHome and setCwd
6848e34
@salimbouch
moved block to setCwd
59f290a 
this block must be executed before createVariables()
@salimbouch
Merge branch 'main' into 102-implement-update-commandlet
16cf912
@salimbouch
javadoc
9655184
@salimbouch
Merge branch '102-implement-update-commandlet' of https://github.com/…
5512031 
…salimbouch/IDEasy into 102-implement-update-commandlet
hohwille
hohwille approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salimbouch thanks for your excellent rework. Now everything looks good and is ready for merge. 👍

@hohwille hohwille merged commit b6a41bd into devonfw:main Apr 8, 2024
4 checks passed
@salimbouch salimbouch deleted the 102-implement-update-commandlet branch April 29, 2024 11:54
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@tobka777 tobka777 added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels May 7, 2024
hohwille added a commit to hohwille/IDEasy that referenced this pull request Jun 28, 2024
@hohwille
devonfw#150: devonfw#101: devonfw#102: reverted code-change that brea…
26130a8 
…ks things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

@aBega2000 aBega2000 aBega2000 approved these changes

Assignees

@hohwille hohwille

@salimbouch salimbouch

Labels
commandlet reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.03.001
Development

Successfully merging this pull request may close these issues.

Implement ability to update IDE instance Implement ability to setup IDE instance
5 participants
@salimbouch @hohwille @coveralls @aBega2000 @tobka777