#183: removed isInstalledVersion()

[MattesMrzik]

Fixes #183. isInstalledVersion() was only used once and caused the duplicate msg if the tool was already installed.

[coveralls]

Pull Request Test Coverage Report for Build 7612283729

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.04%) to 54.912%

---

Totals
Change from base Build 7574035726:	-0.04%
Covered Lines:	3294
Relevant Lines:	5772

---

💛 - Coveralls

[hohwille]

Indeed we have this log message duplicated:

• IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java

  Line 136 in f75bfa6

  this.context.debug("Version {} of tool {} is already installed at {}", resolvedVersion,

• IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java

  Line 45 in f75bfa6

  this.context.debug("{} is already installed at {}", this.tool, binaryPath);

• IDEasy/cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java

  Line 178 in f75bfa6

  this.context.level(level).log("Version {} of tool {} is already installed", installedVersion,

So thanks @MattesMrzik for noticing and taking action to improve. 👍
However, using the silent flag to determine the log-level is an intended behavior we have taken from devonfw-ide.
The idea is as following:

$ devon mvn setup
Version 3.9.6 of tool mvn is already installed

This is the intended default behavior. But also consider this:

$ devon --debug mvn setup
Version 17.0.8 of tool java is already installed
Version 3.9.6 of tool mvn is already installed

By default the user would not expect to get this info about java and that would come every time we run mvn if we log it statically on info or it would come never by default if we log statically on debug so devon java setup would give no feedback at all by default what would be confusing:

$ devon java setup
$

Your change is fine, but you should also add the dynamic logging part from isInstalledVersion method to ToolCommandlet as a protected method that is used by Local/GlobalToolCommandlet. I missed this on the review of #113

UPDATE: I just see that in GlobalToolCommandlet we do not have a version so you could still do what I suggested but allow GlobalToolCommandlet to pass null as version parameter and log accordingly.

[salimbouch]

Just like @hohwille said we need this dynamic logging otherwise we don't get any output when not in debugger mode. If I'm not mistaken you can move isInstalledVersion to ToolCommandlet and use it both in Global and Local, maybe call it isInstalled since Global Tools don't have any version.

[salimbouch]

Looks good to me 👍

[hohwille]

OK, PR does not avoid the redundancies but functionally now correct and ready for merge.
I commented on #52 because of the pointless line-wrapping changes, but this can now be merged. Thanks again 👍