#1822: avoid GitHub redundancies - #1855
Merged
hohwille merged 3 commits intoApr 27, 2026
Merged
Conversation
…evonfw#1822-avoid-github-redundancies
Collaborator
Coverage Report for CI Build 25018284363Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.05%) to 70.689%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
MarvMa
marked this pull request as ready for review
April 27, 2026 08:02
satorus
self-requested a review
April 27, 2026 08:33
Contributor
|
Sieht gut aus, habe es mit dem copilot updater mal lokal getestet. Eine Idee war ja, das man gar keine separaten Updater mehr braucht für Github-basierte Tools sondern alles über ein zentrales GithubRepository abhandeln kann. Wenn ich mir das hier so anschaue, scheint das aber schwierig zu werden, da der Asset-Name leider keinen Konventionen folgt :/ |
satorus
approved these changes
Apr 27, 2026
Member
|
This PR cannot be easily tested e2e. Due to careful review and check of the latest urls updater results, I have set QA approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1822
Implemented changes:
AbstractGithubUrlUpdater.GithubUrlReleaseUpdaterandGithubUrlTagUpdaterto reduce duplicated URL building..../releases/download/...string concatenation.CopilotUrlUpdaterby removing redundant GitHub base URL override.SquirrelSqlUpdaterTestURL matching and addedGithubUrlReleaseUpdaterTestfor convention coverage.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal