Skip to content

#1822: avoid GitHub redundancies - #1855

Merged
hohwille merged 3 commits into
devonfw:mainfrom
MarvMa:feature/#1822-avoid-github-redundancies
Apr 27, 2026
Merged

#1822: avoid GitHub redundancies#1855
hohwille merged 3 commits into
devonfw:mainfrom
MarvMa:feature/#1822-avoid-github-redundancies

Conversation

@MarvMa

@MarvMa MarvMa commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #1822

Implemented changes:

  • Centralized GitHub repository/release URL conventions in AbstractGithubUrlUpdater.
  • Reused shared helpers in GithubUrlReleaseUpdater and GithubUrlTagUpdater to reduce duplicated URL building.
  • Refactored GitHub-based tool updaters to use shared release URL construction instead of manual .../releases/download/... string concatenation.
  • Simplified CopilotUrlUpdater by removing redundant GitHub base URL override.
  • Updated SquirrelSqlUpdaterTest URL matching and added GithubUrlReleaseUpdaterTest for convention coverage.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 27, 2026
@MarvMa MarvMa added enhancement New feature or request urls ide-urls repo and related processes and features internal Nothing to be added to CHANGELOG, only internal story labels Apr 27, 2026
@MarvMa MarvMa moved this from 🆕 New to Team Review in IDEasy board Apr 27, 2026
@MarvMa MarvMa self-assigned this Apr 27, 2026
@coveralls

coveralls commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 25018284363

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.05%) to 70.689%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/tool/squirrelsql/SquirrelSqlUrlUpdater.java 1 84.21%

Coverage Stats

Coverage Status
Relevant Lines: 15337
Covered Lines: 11298
Line Coverage: 73.66%
Relevant Branches: 6846
Covered Branches: 4383
Branch Coverage: 64.02%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@MarvMa
MarvMa marked this pull request as ready for review April 27, 2026 08:02
@satorus satorus self-assigned this Apr 27, 2026
@satorus
satorus self-requested a review April 27, 2026 08:33
@satorus

satorus commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Sieht gut aus, habe es mit dem copilot updater mal lokal getestet.

Eine Idee war ja, das man gar keine separaten Updater mehr braucht für Github-basierte Tools sondern alles über ein zentrales GithubRepository abhandeln kann. Wenn ich mir das hier so anschaue, scheint das aber schwierig zu werden, da der Asset-Name leider keinen Konventionen folgt :/

@hohwille hohwille added this to the release:2026.05.001 milestone Apr 27, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarvMa thanks for your PR.
Looks exactly like the simplification and reduction of redundancies I was hoping for.
Nice work. Also thanks for the extra test. 👍
Ready for merge.

@github-project-automation github-project-automation Bot moved this from Team Review to 👀 In review in IDEasy board Apr 27, 2026
@hohwille
hohwille merged commit d824fdb into devonfw:main Apr 27, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Apr 27, 2026
@hohwille hohwille added the QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. label May 12, 2026
@hohwille

Copy link
Copy Markdown
Member

This PR cannot be easily tested e2e. Due to careful review and check of the latest urls updater results, I have set QA approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. urls ide-urls repo and related processes and features

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Avoid redundancies of Github based url updaters

4 participants