#34: Implemented ToolCommandlet for SonarQube #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java # cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java # cli/src/main/resources/nls/Ide.properties
|
|
Pull Request Test Coverage Report for Build 8250164514Details
💛 - Coveralls |
VinceHeu
reviewed
Feb 21, 2024
VinceHeu
approved these changes
Feb 22, 2024
…onarQube' into feature/implementToolCommandletSonarQube
hohwille
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
@KGoroll1 thanks for your PR. Great work and looking good to me 👍
Regarding the documentation of the commandlets we recently agreed that we stop to redundantly document commandlets in asciidoc as we now have a better help and that should be the source of truth so we can avoid the redundant overhead maintaining the asciidocs that do not add further value.
I will have to check our DoD. In IDEasy the DoD needs to be different to the one in devonfw-ide. I assume that we do not have a DoD in IDEasy so I will have to create a story to add it.
hohwille
added
the
story-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #34
The sonar commandlet has been implemented.
Addressed issue: #34