Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#63: Creating the ide wrapper script #221

Merged
merged 14 commits into from
Mar 12, 2024
Merged

#63: Creating the ide wrapper script #221

merged 14 commits into from
Mar 12, 2024

Conversation

aBega2000
Copy link
Contributor

Fixes #63

@aBega2000 aBega2000 self-assigned this Feb 21, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8249457035

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 58.909%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/log/IdeSubLoggerOut.java 4 68.75%
Totals Coverage Status
Change from base Build 8248998285: 0.002%
Covered Lines: 4046
Relevant Lines: 6620
💛 - Coveralls

@tobka777 tobka777 assigned hohwille and unassigned aBega2000 Feb 26, 2024
hohwille
hohwille requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aBega2000 thanks for your PR. Looks good - nice work👍
Did you actually test the github actions or did you just "guess" these changes? I assume you did some tests to find that natives copy logic in two workflows :)

I left some review comments for rework. Should be easy to complete.

@hohwille
Copy link
Member

hohwille commented Feb 26, 2024 •
edited
Loading

Please also read #63 (comment)

@hohwille hohwille assigned aBega2000 and unassigned hohwille Feb 26, 2024
@aBega2000
Copy link
Contributor Author

I have made the required changed, and the commits contain all the changes that we also discussed. I also managed to fix the diff war by setting the core.autocrlf to false. Therefore the file pom.xml now shows only the changes from the main branch file. I also adapted the Test for the IdeHomeRequired, so that the PR passes all the tests.

@aBega2000 aBega2000 marked this pull request as ready for review March 7, 2024 13:00
@aBega2000 aBega2000 requested a review from hohwille March 11, 2024 09:09
@aBega2000 aBega2000 assigned hohwille and unassigned aBega2000 Mar 11, 2024
hohwille
hohwille approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good now. Ready for merge.

@hohwille hohwille merged commit a71be98 into devonfw:main Mar 12, 2024
3 checks passed
@hohwille hohwille mentioned this pull request Mar 12, 2024
Closed
This was referenced Mar 18, 2024
Closed
Closed
Closed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@tobka777 tobka777 added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ide wrapper script
4 participants
@aBega2000 @coveralls @hohwille @tobka777