#231: improve backup() method to delete junctions in win #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8249652820Details
💛 - Coveralls |
VinceHeu
approved these changes
Feb 29, 2024
hohwille
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
@mvomiero Thank you for your PR. Great that you found, analyzed and fixed the problem. 👍
While your PR is fixing the problem it introduces some code duplication. I added a comment for rework. But apart from that all is fine and then it can be merged.
…hodDeleteJunctionsWin
hohwille
added
bugfix
windows
hohwille
added
the
story-review
tobka777
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #231 by adding a method isJunction() and deleting the file if it is a Junction in the backup() method.