Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#256: improve package manager API #274

Merged
merged 17 commits into from
Apr 19, 2024
Merged

#256: improve package manager API #274

merged 17 commits into from
Apr 19, 2024

Conversation

salimbouch
Copy link
Contributor

closes #256

@coveralls
Copy link
Collaborator

coveralls commented Apr 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8756100142

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 127 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.07%) to 59.635%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/docker/Docker.java 7 6.9%
com/devonfw/tools/ide/tool/PackageManager.java 8 0.0%
com/devonfw/tools/ide/process/ProcessContextImpl.java 15 76.49%
com/devonfw/tools/ide/tool/GlobalToolCommandlet.java 20 2.38%
com/devonfw/tools/ide/context/AbstractIdeContext.java 77 57.94%
Totals Coverage Status
Change from base Build 8756057910: 0.07%
Covered Lines: 4559
Relevant Lines: 7354
💛 - Coveralls

@salimbouch salimbouch marked this pull request as ready for review April 18, 2024 12:21
@salimbouch salimbouch requested a review from hohwille April 19, 2024 08:35
hohwille
hohwille approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salimbouch thanks for your rework to make it perfect 👍
Ready for merge now.

@hohwille hohwille merged commit f23348b into devonfw:main Apr 19, 2024
4 checks passed
@hohwille hohwille added this to the release:2024.04.001 milestone Apr 19, 2024
@hohwille hohwille added the enhancement New feature or request label Apr 19, 2024
@hohwille hohwille added install installation process of IDE + tools and install commandlet linux specific for linux OS (debian, ubunutu, suse, etc.) macOS specific for Apple MacOS labels Apr 19, 2024
@hohwille hohwille mentioned this pull request Apr 19, 2024
Closed
@salimbouch salimbouch deleted the 256-improve-package-manager branch May 3, 2024 01:09
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@hohwille hohwille added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

Labels
enhancement New feature or request install installation process of IDE + tools and install commandlet linux specific for linux OS (debian, ubunutu, suse, etc.) macOS specific for Apple MacOS reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.04.001
Development

Successfully merging this pull request may close these issues.

Improve package manager installation from PR 249
3 participants
@salimbouch @coveralls @hohwille