#182 Implement global tool installation for pgadmin #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9497337449Details
💛 - Coveralls |
slskiba
commented
Jun 20, 2024
cli/src/main/java/com/devonfw/tools/ide/tool/pgadmin/PgAdmin.java
Outdated
Show resolved
Hide resolved
hohwille
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
@slskiba thanks for your PR. Solid work. Great that you already tested different OS and crafted a linux specific solution as well. 👍
You will need to merge with main, resolve conflicts and then add the help details properties as well.
If review comments are addressed, this can be merged.
cli/src/main/java/com/devonfw/tools/ide/tool/pgadmin/PgAdminUrlUpdater.java
Show resolved
Hide resolved
# Conflicts: # cli/src/main/resources/nls/Help.properties # cli/src/main/resources/nls/Help_de.properties
Pull Request Test Coverage Report for Build 9641057892Details
💛 - Coveralls |
|
The installWithPackageManager method of GlobalToolCommandlet has been renamed to runWithPackageManager, since it can be used to uninstall tools without changes to the code. |
Pull Request Test Coverage Report for Build 9643058290Details
💛 - Coveralls |
hohwille
added
the
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #182.
Installation on Mac is unsuccessful due to getting a "Permission Denied" error. This problem is handled in #402.