Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#395 Uninstall graalvm successfully #397

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

slskiba
Copy link
Contributor

@slskiba slskiba commented Jun 18, 2024

Fixes #395.

  • Moved uninstall method into ToolCommandlet, to allow for tool-specific uninstallation processes
  • Moved current uninstall logic to LocalToolCommandlet, as it only is viable for local tools
  • Implemented placeholder uninstall method for GlobalToolCommandlet
  • use getToolPath to locate the installed tool, thus fixing the graalvm uninstall error

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9566571256

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.004%) to 60.055%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/GlobalToolCommandlet.java 2 2.33%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 2 78.26%
com/devonfw/tools/ide/tool/ToolCommandlet.java 11 74.1%
Totals Coverage Status
Change from base Build 9552528477: -0.004%
Covered Lines: 4724
Relevant Lines: 7565

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for your PR. You are rocket fast madam :) Excellent solution.
Nice since with using getToolPath() it will now automatically work even for GraalVm without overriding uninstall logic. Nice job 👍
I left some minimal comments but can be merged.

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9567914514

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 190 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.03%) to 60.031%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/nls/NlsBundle.java 1 82.5%
com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java 2 74.07%
com/devonfw/tools/ide/tool/GlobalToolCommandlet.java 2 2.33%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 2 78.07%
com/devonfw/tools/ide/tool/jasypt/Jasypt.java 2 82.5%
com/devonfw/tools/ide/commandlet/HelpCommandlet.java 2 93.83%
com/devonfw/tools/ide/variable/VariableDefinition.java 3 57.14%
com/devonfw/tools/ide/environment/EnvironmentVariablesMap.java 5 60.0%
com/devonfw/tools/ide/variable/VariableDefinitionPath.java 5 55.56%
com/devonfw/tools/ide/context/IdeContext.java 11 42.55%
Totals Coverage Status
Change from base Build 9552528477: -0.03%
Covered Lines: 4762
Relevant Lines: 7625

💛 - Coveralls

@hohwille hohwille added uninstall uninstall tools or IDEasy itself graalvm GraalVM, native-image, truffle, etc. labels Jun 21, 2024
@hohwille hohwille merged commit ee596da into devonfw:main Jun 21, 2024
3 checks passed
@hohwille hohwille added this to the release:2024.06.002 milestone Jun 21, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9609977471

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.007%) to 60.67%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/GlobalToolCommandlet.java 2 2.33%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 2 78.07%
com/devonfw/tools/ide/tool/ToolCommandlet.java 11 74.1%
Totals Coverage Status
Change from base Build 9600502268: -0.007%
Covered Lines: 4940
Relevant Lines: 7834

💛 - Coveralls

@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graalvm GraalVM, native-image, truffle, etc. reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. uninstall uninstall tools or IDEasy itself
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Uninstall graalvm is not successful, fails to find installed version
3 participants