-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#395 Uninstall graalvm successfully #397
#395 Uninstall graalvm successfully #397
Conversation
Pull Request Test Coverage Report for Build 9566571256Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slskiba thanks for your PR. You are rocket fast madam :) Excellent solution.
Nice since with using getToolPath()
it will now automatically work even for GraalVm
without overriding uninstall logic. Nice job 👍
I left some minimal comments but can be merged.
cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 9567914514Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9609977471Details
💛 - Coveralls |
Fixes #395.