-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#171: support for multiple VariableSyntax styles #407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9613602697Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9615912827Details
💛 - Coveralls |
@slskiba did some review and could not find concerns but also not verify all changes as reported today in daily meeting. |
Pull Request Test Coverage Report for Build 9660943470Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
reviewed
Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #171
VariableSyntax
enum incl. testEnvironmentVariables
by addingresolve
method variant withboolean legacySupport
for workspace mergerIdeVariables.IDE_VARIABLE_SYNTAX_LEGACY_SUPPORT_ENABLED
FileMerger
and implementations to use this new variableAbstractEnvironmentVariables
implemetingresolve
andinverseResolve
methods.