Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#171: support for multiple VariableSyntax styles #407

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

hohwille
Copy link
Member

fixes #171

  • Add VariableSyntax enum incl. test
  • Extend EnvironmentVariables by adding resolve method variant with boolean legacySupport for workspace merger
  • Add IdeVariables.IDE_VARIABLE_SYNTAX_LEGACY_SUPPORT_ENABLED
  • Extend workspace FileMerger and implementations to use this new variable
  • Refactor AbstractEnvironmentVariables implemeting resolve and inverseResolve methods.
  • Improve logging, change log-level dynamically for legacy support case

@hohwille hohwille added this to the release:2024.06.002 milestone Jun 21, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9613602697

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.01%) to 60.682%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/merge/FileMerger.java 4 33.33%
com/devonfw/tools/ide/environment/EnvironmentVariables.java 7 81.36%
com/devonfw/tools/ide/merge/xmlmerger/XmlMerger.java 10 77.78%
com/devonfw/tools/ide/merge/JsonMerger.java 12 77.33%
com/devonfw/tools/ide/merge/PropertiesMerger.java 15 41.67%
com/devonfw/tools/ide/environment/AbstractEnvironmentVariables.java 20 78.24%
Totals Coverage Status
Change from base Build 9610011440: 0.01%
Covered Lines: 4972
Relevant Lines: 7883

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9615912827

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 130 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.06%) to 60.613%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/merge/FileMerger.java 4 33.33%
com/devonfw/tools/ide/environment/EnvironmentVariables.java 7 81.36%
com/devonfw/tools/ide/context/IdeContext.java 7 45.28%
com/devonfw/tools/ide/merge/xmlmerger/XmlMerger.java 10 77.78%
com/devonfw/tools/ide/merge/JsonMerger.java 12 77.33%
com/devonfw/tools/ide/merge/PropertiesMerger.java 15 41.67%
com/devonfw/tools/ide/environment/AbstractEnvironmentVariables.java 20 78.24%
com/devonfw/tools/ide/step/Step.java 20 36.36%
com/devonfw/tools/ide/tool/mvn/Mvn.java 35 41.54%
Totals Coverage Status
Change from base Build 9610011440: -0.06%
Covered Lines: 4981
Relevant Lines: 7905

💛 - Coveralls

@hohwille hohwille self-assigned this Jun 21, 2024
@hohwille
Copy link
Member Author

@slskiba did some review and could not find concerns but also not verify all changes as reported today in daily meeting.
I will merge this today as we need this feature for devonfw/ide-settings#51.

@coveralls
Copy link
Collaborator

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9660943470

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 130 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.06%) to 60.42%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/merge/FileMerger.java 4 33.33%
com/devonfw/tools/ide/environment/EnvironmentVariables.java 7 81.36%
com/devonfw/tools/ide/context/IdeContext.java 7 45.28%
com/devonfw/tools/ide/merge/xmlmerger/XmlMerger.java 10 77.78%
com/devonfw/tools/ide/merge/JsonMerger.java 12 77.33%
com/devonfw/tools/ide/merge/PropertiesMerger.java 15 41.67%
com/devonfw/tools/ide/environment/AbstractEnvironmentVariables.java 20 78.24%
com/devonfw/tools/ide/step/Step.java 20 36.36%
com/devonfw/tools/ide/tool/mvn/Mvn.java 35 41.54%
Totals Coverage Status
Change from base Build 9658247376: -0.06%
Covered Lines: 4985
Relevant Lines: 7942

💛 - Coveralls

@hohwille hohwille merged commit b90732f into devonfw:main Jun 25, 2024
4 checks passed
@jan-vcapgemini jan-vcapgemini added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Avoid log-spam from EnvironmentVariables.resolve
3 participants