Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#523: exclude files from wrong OS #562

Merged

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Aug 26, 2024

fixes #523

  • exclude files from wrong OS in assembly files
  • fix XSD link to https

Also fix OS and arch classifier to follow our own standard (see ide-urls).
Was also specified in #427:

Actually I would expect that either in the workflow build or in our CLI POM or in the assembly we define that we want to have a release for win-x64, max-x64, mac-arm, linux-x64 (and potentially more)
See also #251

Fun fact is that even without this change, we got releases with windows-x64, mac-arm, etc. as specified so it worked.
The question is why did it work? At least the release artifact filenames in the target-folder are derived from these assembly IDs and have been somehow inconsistent, so for me this change makes sense.
UPDATE: I was blind. Each file is mapped in the POM. All non-sense because we never completed what I was trying to say in issues like #427
See also my comment on Teams:

Ich hatte ja mal vorgeschlagen, dass wir in den matrix.os VMs nur das native image bauen (ideasy[.exe]) und das danach ins release einbauen, d.h. wir bauen 4 Assemblies die jeweils ein eigenes natives image nutzen, was im matrix.os build hochgeladen und danach im Gesamt-Build wieder runtergeladen wurde. Dann brauchen wir auch die Dokumentation nicht davor extra zu bauen und diese ganzen komischen Verrenkungen nicht machen und das Assembly-Plugin kann auch die Artefakte attachen und wir brauchen dafür kein extra build-helper-plugin. Dann wird es m.E. auch wieder konsistent.

Created new issue #563 for that.

For the record: I had a long long discussion with @jan-vcapgemini if our arch classifiers are OK or not.
We could easily agree that arm is correct and should be preferred over aarch.
We can also agree that 32-Bit is to be considered dead.
That we use x64 what actually stands for x86-64 on the one hand and arm without any 64 is kind of inconsistent.
My argument was however, that this was specified long time ago in devonfw-ide and the entire ide-urls repo is based on this convention. Changing this in IDEasy would require to change or rebuild the entire ide-urls repo and that would even break devonfw-ide. So consider this as given by legacy if you do not like it.
Might be more logical if we would instead have

  • x64 and arm64
  • or x86 and arm
  • or x86-64 and arm-64

However, we simply have x64 and arm and that is somehow curved in stone so we better follow strictly our own conventions instead of doing something different in various places.

@hohwille hohwille added this to the release:2024.09.001 milestone Aug 26, 2024
@hohwille hohwille added enhancement New feature or request windows specific for Microsoft Windows OS macOS specific for Apple MacOS linux specific for linux OS (debian, ubunutu, suse, etc.) system OS-specific tweaks found in the system folder. release related to release commandlet and releases of IDEasy labels Aug 26, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10581881867

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 65.071%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/url/model/file/UrlDependencyFile.java 1 70.0%
Totals Coverage Status
Change from base Build 10579061553: -0.02%
Covered Lines: 5729
Relevant Lines: 8494

💛 - Coveralls

@hohwille
Copy link
Member Author

Our builds now fail with this error:

Run coveralls report        
coveralls: error while loading shared libraries: libevent-2.1.so.7: cannot open shared object file: No such file or directory
Error: Process completed with exit code 127.

Not related to the changes at all but some infrastructural problem of coveralls.
If that persists, we need to disable coveralls but first lets wait 24h or so.

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can be merged as soon as the comment was added.

@hohwille hohwille merged commit d46fd0d into devonfw:main Aug 27, 2024
3 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linux specific for linux OS (debian, ubunutu, suse, etc.) macOS specific for Apple MacOS release related to release commandlet and releases of IDEasy reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. system OS-specific tweaks found in the system folder. windows specific for Microsoft Windows OS
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove files specific for other OS from releases
3 participants