-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#523: exclude files from wrong OS #562
Merged
hohwille
merged 9 commits into
devonfw:main
from
hohwille:feature/523-exclude-files-for-other-os
Aug 27, 2024
Merged
#523: exclude files from wrong OS #562
hohwille
merged 9 commits into
devonfw:main
from
hohwille:feature/523-exclude-files-for-other-os
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10581881867Details
💛 - Coveralls |
5 tasks
Our builds now fail with this error:
Not related to the changes at all but some infrastructural problem of coveralls. |
hohwille
commented
Aug 27, 2024
jan-vcapgemini
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can be merged as soon as the comment was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
linux
specific for linux OS (debian, ubunutu, suse, etc.)
macOS
specific for Apple MacOS
release
related to release commandlet and releases of IDEasy
reviewed
Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
system
OS-specific tweaks found in the system folder.
windows
specific for Microsoft Windows OS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #523
Also fix OS and arch classifier to follow our own standard (see ide-urls).
Was also specified in #427:
Fun fact is that even without this change, we got releases with
windows-x64
,mac-arm
, etc. as specified so it worked.The question is why did it work? At least the release artifact filenames in the target-folder are derived from these assembly IDs and have been somehow inconsistent, so for me this change makes sense.
UPDATE: I was blind. Each file is mapped in the POM. All non-sense because we never completed what I was trying to say in issues like #427
See also my comment on Teams:
Created new issue #563 for that.
For the record: I had a long long discussion with @jan-vcapgemini if our arch classifiers are OK or not.
We could easily agree that
arm
is correct and should be preferred overaarch
.We can also agree that 32-Bit is to be considered dead.
That we use
x64
what actually stands forx86-64
on the one hand andarm
without any64
is kind of inconsistent.My argument was however, that this was specified long time ago in
devonfw-ide
and the entireide-urls
repo is based on this convention. Changing this in IDEasy would require to change or rebuild the entireide-urls
repo and that would even breakdevonfw-ide
. So consider this as given by legacy if you do not like it.Might be more logical if we would instead have
x64
andarm64
x86
andarm
x86-64
andarm-64
However, we simply have
x64
andarm
and that is somehow curved in stone so we better follow strictly our own conventions instead of doing something different in various places.