#628: Fixed update fails on first error #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added catch of exceptions for ToolCommandlet installations converted steps to try-with-resources added new test for failed update substeps added mvn and java repositories to update test-project
jan-vcapgemini
added
update
Pull Request Test Coverage Report for Build 10956585846Details
💛 - Coveralls |
hohwille
reviewed
Sep 20, 2024
There was a problem hiding this comment.
@jan-vcapgemini thanks for your PR. Great work with nice and consistent improvements. I very much appreciate if you care for clean code like improving all places to try-with-resource syntax and extending with a test of the according situation. 👍
During the review I thought further and IMHO identified a deeper problem that goes beyond the initial demand of story #628. Could you have a look and we can then discuss if it makes sense to extend this PR or if we want to create a new story for that...?
cli/src/main/java/com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/UpdateCommandletTest.java
Show resolved
Hide resolved
|
https://github.com/devonfw/IDEasy/blob/main/documentation/DoD.adoc
|
…ateCommandlet.java Co-authored-by: Jörg Hohwiller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #628
Implements: