Skip to content

build(deps-dev): bump cucumber.version from 6.11.0 to 7.0.0 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

build(deps-dev): bump cucumber.version from 6.11.0 to 7.0.0 #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0363782
build(deps-dev): bump cucumber.version from 6.11.0 to 7.0.0
dependabot[bot] Oct 6, 2021
0730ef0
build(deps-dev): bump cucumber.version from 6.11.0 to 7.0.0
dependabot[bot] Oct 7, 2021
3938346
refactor(acceptance-test): remove deprecated strict from @CucumberOpt…
paul58914080 Oct 7, 2021
d437a3f
build: merge with main
paul58914080 Oct 7, 2021
8aea54c
Merge branch 'main' of https://github.com/devs-from-matrix/hexagonal-…
paul58914080 Oct 7, 2021
06bec29
temp: junit bom
paul58914080 Oct 27, 2021
d445d66
build: simplified dependencies
paul58914080 Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions acceptance-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,36 +31,18 @@
<artifactId>cucumber-java8</artifactId>
<version>${cucumber.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<artifactId>apiguardian-api</artifactId>
<groupId>org.apiguardian</groupId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.cucumber</groupId>
<artifactId>cucumber-junit</artifactId>
<artifactId>cucumber-junit-platform-engine</artifactId>
<version>${cucumber.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<artifactId>apiguardian-api</artifactId>
<groupId>org.apiguardian</groupId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>io.cucumber</groupId>
<artifactId>cucumber-spring</artifactId>
<version>${cucumber.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<artifactId>apiguardian-api</artifactId>
<groupId>org.apiguardian</groupId>
</exclusion>
</exclusions>
</dependency>
</dependencies>
<build>
Expand Down
3 changes: 0 additions & 3 deletions acceptance-test/src/test/kotlin/packagename/AcceptanceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import org.assertj.core.api.Assertions.assertThat
import org.assertj.core.api.Assertions.assertThatThrownBy
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.extension.ExtendWith
import org.junit.platform.runner.JUnitPlatform
import org.junit.runner.RunWith
import org.mockito.Mock
import org.mockito.Mockito
import org.mockito.junit.jupiter.MockitoExtension
Expand All @@ -16,7 +14,6 @@ import packagename.domain.port.ObtainExample
import java.util.*

@ExtendWith(MockitoExtension::class)
@RunWith(JUnitPlatform::class)
class AcceptanceTest {

@Test
Expand Down
5 changes: 3 additions & 2 deletions acceptance-test/src/test/kotlin/packagename/cucumber/ExampleStepDef.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ class ExampleStepDef(restTemplate: TestRestTemplate, exampleDao: ExampleDao) : E

init {

DataTableType { row: Map<String, String> -> Example(row["code"].toString().toLong(), row["description"].toString()) }
DataTableType { row: Map<String, String> -> ExampleEntity(code = row["code"].toString().toLong(), description = row["description"].toString()) }
// DataTableType { row: Map<String, String> -> Example(row["code"].toString().toLong(), row["description"].toString()) }
// DataTableType { row: Map<String, String> -> ExampleEntity(code = row["code"].toString().toLong(), description = row["description"].toString()) }


Before { _ -> exampleDao.deleteAll() }
After { _ -> exampleDao.deleteAll() }
Expand Down
21 changes: 12 additions & 9 deletions acceptance-test/src/test/kotlin/packagename/cucumber/RunCucumberExampleTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
package packagename.cucumber

import io.cucumber.junit.Cucumber
import io.cucumber.junit.CucumberOptions
import org.junit.runner.RunWith
import io.cucumber.junit.platform.engine.Constants.*
import org.junit.platform.suite.api.*

@RunWith(Cucumber::class)
@CucumberOptions(features = ["classpath:features/example.feature"],
strict = true,
plugin = ["json:target/cucumber/example.json", "json:target/cucumber/example.xml"],
tags = "@Example",
glue = ["classpath:packagename.cucumber"])
@Suite
@IncludeEngines("cucumber")
@SelectClasspathResource("features")
@ConfigurationParameters(
ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "packagename.cucumber"), // this is the part where the stepdef file is
ConfigurationParameter(key = FILTER_TAGS_PROPERTY_NAME, value = "@Example"),
ConfigurationParameter(key = JUNIT_PLATFORM_NAMING_STRATEGY_PROPERTY_NAME, value = "long"),
ConfigurationParameter(key = PLUGIN_PUBLISH_QUIET_PROPERTY_NAME, value = "true"),
ConfigurationParameter(key = PLUGIN_PROPERTY_NAME, value = "json:target/cucumber/cucumber.json")
)
class RunCucumberExampleTest
31 changes: 12 additions & 19 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@
<kotlin.version>1.5.31</kotlin.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<spring-boot.version>2.5.5</spring-boot.version>
<cucumber.version>6.11.0</cucumber.version>
<junit-jupiter.version>5.8.1</junit-jupiter.version>
<spring-boot.version>2.5.6</spring-boot.version>
<cucumber.version>7.0.0</cucumber.version>
<springdoc.version>1.5.11</springdoc.version>
<pre-liquibase.version>1.1.1</pre-liquibase.version>
<!-- plugins -->
Expand Down Expand Up @@ -81,6 +82,13 @@
<version>${project.version}</version>
</dependency>
<!-- Frameworks & Libraries -->
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>${junit-jupiter.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId>
Expand Down Expand Up @@ -111,27 +119,12 @@
<!-- JUnit 5 dependencies -->
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-launcher</artifactId>
<artifactId>junit-jupiter</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-runner</artifactId>
<artifactId>junit-platform-suite</artifactId>
<scope>test</scope>
</dependency>
<!-- mockito dependencies -->
Expand Down