add reboot machine option #58
Conversation
| fi | ||
|
|
||
| # Reboot machine | ||
| if [ "${REBOOT:-}" = "true" ]; then |
There was a problem hiding this comment.
There is section at very beguining of the file for default, even when this can be checked without value it may worthwile for reading purposes to add the control default value there
There was a problem hiding this comment.
Why do we need this? Can we add more context? and also make it a bit more explicit on the commit message.
Also does it make sense to reboot and wait? Otherwise if you reboot the next action (or step) needs to know connection will not be ready ...as so it will need to add the check mechanism
entrypoint.sh
Outdated
|
|
||
| # Reboot machine | ||
| if [ "${REBOOT:-}" = "true" ]; then | ||
| reboot_cmd="$(ssh_cmd sudo reboot)" |
There was a problem hiding this comment.
sudo reboot will work for Linux and most probably for Darwin? (check it), but it will not work for Windows. we need to set an specific cmd per platform
|
@adrianriobo The linux machine still meet crc stuck issue. We need to reboot the machine to let it work again. |
lilyLuLiu
force-pushed
the
add_reboot
branch
from
7cd2271 to
8bf03fe
Compare
lilyLuLiu
force-pushed
the
add_reboot
branch
from
8bf03fe to
bd21959
Compare
No description provided.