Skip to content

Skip vibration when a subagent stops - #7

Merged
devxoul merged 1 commit into
mainfrom
skip-subagent-stop
Oct 26, 2026
Merged

devxoul merged 1 commit into
mainfrom
skip-subagent-stop

Conversation

@devxoul

@devxoul devxoul commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Summary

In omo (senpi), the pi extension vibrated whenever a subagent finished, as well as when the main agent stopped. omo runs category subagents as RPC sessions, and those report a UI, so the ctx.hasUI guard let them through.

Changes

  • isSubagentSession recognizes omo subagents the same way omo does: shared-host children are opened with sessionKind: "worker", standalone RPC children carry OMO_SENPI_TASK_RPC_CHILD=1, and team members carry SENPI_TASK_MEMBER
  • The agent_end handler skips vibration for those sessions
  • Tests for each detection path

@devxoul
devxoul force-pushed the skip-subagent-stop branch from 15872fb to 104f02a Compare October 26, 2026 15:01

@typeey typeey Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes line-by-line at 104f02a; no actionable defects found. Exact-head CI passed typecheck, lint, tests, and build.

Upstream senpi contracts and live haptic behavior were not independently validated.

@devxoul
devxoul merged commit 8eb92af into main Oct 26, 2026
3 checks passed
@devxoul
devxoul deleted the skip-subagent-stop branch October 26, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant