update motoko basic_bitcoin readme #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altkdf
commented
Oct 8, 2024
| @@ -226,15 +229,4 @@ For example, the following aspects are particularly relevant for this app: | |||
| * [Certify query responses if they are relevant for security](https://internetcomputer.org/docs/current/references/security/general-security-best-practices#certify-query-responses-if-they-are-relevant-for-security), since the app e.g. offers a method to read balances. | |||
| * [Use a decentralized governance system like SNS to make a canister have a decentralized controller](https://internetcomputer.org/docs/current/developer-docs/security/security-best-practices/overview) | |||
|
|
|||
| ## Taproot transactions | |||
There was a problem hiding this comment.
This information is redundant because already included in the description of the addresses.
There was a problem hiding this comment.
Optionally you can add in the above address description that untweaked P2TR transactions have the limitation that they cannot be used in combination with scripts.
There was a problem hiding this comment.
added a sentence about it
fspreiss
approved these changes
Oct 11, 2024
| @@ -226,15 +229,4 @@ For example, the following aspects are particularly relevant for this app: | |||
| * [Certify query responses if they are relevant for security](https://internetcomputer.org/docs/current/references/security/general-security-best-practices#certify-query-responses-if-they-are-relevant-for-security), since the app e.g. offers a method to read balances. | |||
| * [Use a decentralized governance system like SNS to make a canister have a decentralized controller](https://internetcomputer.org/docs/current/developer-docs/security/security-best-practices/overview) | |||
|
|
|||
| ## Taproot transactions | |||
There was a problem hiding this comment.
Optionally you can add in the above address description that untweaked P2TR transactions have the limitation that they cannot be used in combination with scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example now also supports taproot.