fix(ICRC_Ledger): FI-1654: Update link to script that downloads latest ICRC ledger

[mbjorkqvist]

The script that downloads the latest ICRC ledger wasm and did files was recently updated to download them using the official ledger releases, rather than the latest commit on the master branch of the ic repository.

The links to the script in the documentation point to a specific commit in the ic repository. This PR proposes to update the links to the commit where the script was updated, so that users end up with an officially released ledger.

[marc0olo]

I just want to refer to a recent PR and discussion in that regard where I fixed the link and general and wanted to switch to master for the download script 😅

see #1081

I assume this would have prevented the need for this PR. not sure if there is a really good path to tackle this. maybe there should be a more common place for the script to be stored along with other useful scripts 🤔

[marc0olo]

@mbjorkqvist just to be sure, the ICP ledger download script did not change, right?

[mbjorkqvist]

Thanks for the review and feedback, @marc0olo!

I just want to refer to a recent PR and discussion in that regard where I fixed the link and general and wanted to switch to master for the download script 😅

see #1081

I assume this would have prevented the need for this PR. not sure if there is a really good path to tackle this. maybe there should be a more common place for the script to be stored along with other useful scripts 🤔

Thanks for the pointer! I'd rather point to a specific commit in this case, since there is a non-negligible chance that the files get renamed or moved, in which case the user may have a hard time finding the correct one. In fact, the script would IMO fit better under rs/ledger_suite/scripts than under rs/rosetta-api/scripts, so it may move in the near future, but that would be part of a somewhat larger cleanup item, so I don't want to move it now.

@mbjorkqvist just to be sure, the ICP ledger download script did not change, right?

No, it didn't change (yet). We are planning to create ICP ledger suite releases similar to the ones we now have for the ICRC ledger suite, starting from the next ICP ledger suite version, which is planned for the next week or two, in which case we'd want to update that script also. We have the FI-1647 JIRA ticket for updating the script when the release is done.

[letmejustputthishere]

@mbjorkqvist can you please ping us so we can make sure to update the examples READMEs as well. @marc0olo did you update the examples with the current commit hash already, or should we wait for two weeks until FI provides the new scripts?
EDIT: nvm, mixed up the PRs and now see mathias already provided PRs for both portal and examples