chore: [NODE-1683] Remove deprecated VM fields #7037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This pull request modifies the IC-OS configuration types library (rs/ic_os/config_types/src/lib.rs).
Please ensure you have followed the Configuration Update Protocol guidelines——particularly if adding a new enum or enum variants:
Enum Variant Forward Compatibility Guidelines: If adding a new enum or new variants to an enum, ensure older versions can handle unknown variants gracefully by using #[serde(other)] on a fallback variant. See examples: GuestVMType::Unknown and Ipv6Config::Unknown.
To acknowledge this reminder and unblock the PR, dismiss this code review by:
- Going to the bottom of the pull request page
- Finding where this bot is requesting changes
- Clicking the three dots on the right
- Selecting "Dismiss review"
For complete guidelines, see the documentation at the top of rs/ic_os/config_types/src/lib.rs.
CONFIG_TYPES_COMPATIBILITY_REMINDER_DEDUP
Bownairo
force-pushed
the
eero/lower-mem
branch
3 times, most recently
from
783448f to
c30e324
Compare
Bownairo
force-pushed
the
eero/delete-dev
branch
6 times, most recently
from
9fb93d6 to
5addf7e
Compare
Bownairo
force-pushed
the
eero/delete-dev
branch
from
5addf7e to
782f23c
Compare
Bownairo
force-pushed
the
eero/delete-dev
branch
from
782f23c to
07225d8
Compare
Bownairo
changed the title
andrewbattat
approved these changes
Dec 8, 2025
basvandijk
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.