-
Notifications
You must be signed in to change notification settings - Fork 368
feat(governance): Added BlessAlternativeGuestOsVersion proposal type. #7904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daniel-wong-dfinity-org
wants to merge
20
commits into
master
Choose a base branch
from
subnet-recovery-proposal-type-daniel-wong
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d34142b
Added DeclareAlternativeReplicaVirtualMachineSoftwareSet.
daniel-wong-dfinity-org 2d4fa51
validation. This was mostly done by Antigravity. Impressive. Much toi…
daniel-wong-dfinity-org 4bae097
tests
daniel-wong-dfinity-org 188bb8c
Added flag for new DeclareAlternativeReplicaVirtualMachineSoftwareSet…
daniel-wong-dfinity-org 7ef5f29
Updated governance.did.
daniel-wong-dfinity-org ff64fbe
Moved a test help function so that it can be used in more places. Wil…
daniel-wong-dfinity-org 0f9a5dd
metadata is optional.
daniel-wong-dfinity-org 0f63ade
Renamed to BlessAlternativeGuestOsVersion.
daniel-wong-dfinity-org d085aa1
Renamed field to rootfs_hash.
daniel-wong-dfinity-org 0212c2f
AI referenced a specific section in an AMD spec, but we cannot find i…
daniel-wong-dfinity-org 650b669
Minor technical clarification about what a guest launch measurement is.
daniel-wong-dfinity-org 6e70ea6
Mention that SHA-256 is used for rootfs_hash.
daniel-wong-dfinity-org 75e292c
typo: removed extraneous "e".
daniel-wong-dfinity-org b16d22e
Removed some extraneous conversions.
daniel-wong-dfinity-org 7a37116
tiny refactor: let Some(...) instead of match.
daniel-wong-dfinity-org 135da77
Clarify what "base" means in `base_guest_launch_measurements`.
daniel-wong-dfinity-org f833b91
Use authoritative definition of GuestLaunchMeasurements et. al.
daniel-wong-dfinity-org 4a74665
Move validation to rs/protobuf.
daniel-wong-dfinity-org 634c5f6
lint
daniel-wong-dfinity-org 1512aa2
Stuff explodes when you indent numbered lists. Because Markdown.
daniel-wong-dfinity-org File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.