feat: add support for CRITERION_HOME #7979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new CLI argument `--criterion-home` that we intercept and use to set `CRITERION_HOME` for the bench runner. See comment in code for details. This allows us to specify the criterion root (home) where we start looking for bench dirs, in order to avoid false positives from `bazel-out/`.
nmattia
commented
Dec 8, 2025
basvandijk
approved these changes
Dec 8, 2025
Co-authored-by: Bas van Dijk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new CLI argument
--criterion-homethat we intercept and use to setCRITERION_HOMEfor the bench runner. See comment in code for details.This allows us to specify the criterion root (home) where we start looking for bench dirs, in order to avoid false positives from
bazel-out/.