Skip to content

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Sep 9, 2025

core is now included, so run latest motoko-matchers with a core package.

While matchers internally uses core, it has been retrofitted to work with base too. So we can now test both core and base with matchers.

ggreif and others added 3 commits September 9, 2025 18:06
Let's see if `core` is now included.
and pull from PR sources for now
@ggreif ggreif force-pushed the gabor/matchers-core branch 2 times, most recently from 1b8742a to 7a16f63 Compare September 9, 2025 19:33
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Comparing from bbe13bd to 0efe8c1:
The produced WebAssembly code seems to be completely unchanged.
In terms of gas, no changes are observed in 5 tests.
In terms of size, no changes are observed in 5 tests.

@christoph-dfinity
Copy link
Contributor

[email protected] switches from base to core. As this code is running bases test-suite it should probably stick to [email protected].

ggreif and others added 2 commits September 11, 2025 12:51
`matchers` has a release now
@ggreif
Copy link
Contributor Author

ggreif commented Sep 11, 2025

[email protected] switches from base to core. As this code is running bases test-suite it should probably stick to [email protected].

I don't quite understand. It appears that [email protected] easily can test base (see dfinity/motoko-base#736). The relevant functionality should now be present.

@ggreif ggreif self-assigned this Sep 11, 2025
@ggreif ggreif added the testing Related to test suite label Sep 11, 2025
@ggreif ggreif marked this pull request as ready for review September 11, 2025 15:07
@ggreif ggreif requested a review from a team as a code owner September 11, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE testing Related to test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants