-
Notifications
You must be signed in to change notification settings - Fork 118
experiment: add implicit
keyword and dedicated grammar
#5521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
crusso
wants to merge
32
commits into
master
Choose a base branch
from
claudio/implicits-keyword
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
037c74d
to
bd9076b
Compare
This was referenced Sep 28, 2025
I'd suggest func sort<T>( array : [T], compare : implicit (Nat, Nat) -> Order) {};
: <T>( array : [], with compare : (Nat, Nat) -> Order) -> ()
|
crusso
commented
Oct 4, 2025
implicit-import-hint.mo:11.8-11.18: type error [M0230], Cannot determine implicit argument 'compare' of type | ||
(Text, Text) -> Order | ||
Hint: Did you mean to import mo:core/Text? | ||
Hint: Did you mean to import core-stub/src/Text.mo.compare? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A regression?
crusso
commented
Oct 4, 2025
{chars : () -> {next : () -> ?Char}; size : () -> Nat} | ||
The field compare is not available. Try something else? | ||
Hint: Did you mean to import mo:core/Text? | ||
Hint: Did you mean to import core-stub/src/Text.mo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A regression?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on #5517
add
implicit
keyword and grammer production (so a minor breaking change)expands
implicit t
to a named type. Sinceimplicit
is now a keyword, users can't just use identifierimplicit
as name for a traditional named type (or anything else for that matter).extends pretty printer, parser and various other bits and bobs.
Let's you write and read:
instead of raw syntax and types:
(fewer
(..)
and:
)merge with master
fix merge (regen tests)