Skip to content

Conversation

Kamirus
Copy link
Member

@Kamirus Kamirus commented Oct 10, 2025

Introduce a new ImplicitLibE expression node for the implicitly imported modules used for ctx-dot and implicits.

Copy link
Contributor

github-actions bot commented Oct 10, 2025

Comparing from 2bac734 to 4b93ef4:
The produced WebAssembly code seems to be completely unchanged.
In terms of gas, no changes are observed in 5 tests.
In terms of size, no changes are observed in 5 tests.

@crusso
Copy link
Contributor

crusso commented Oct 12, 2025

Looks promising!

@Kamirus Kamirus changed the title feat: Cleanup implicit lib vals chore: Cleanup implicit lib vals Oct 13, 2025
@Kamirus Kamirus marked this pull request as ready for review October 13, 2025 11:50
@Kamirus Kamirus requested a review from a team as a code owner October 13, 2025 11:50
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think one could simplify a bit further but let's go with this for now

@Kamirus Kamirus enabled auto-merge (squash) October 14, 2025 09:53
@Kamirus Kamirus merged commit 134d4b5 into master Oct 14, 2025
20 checks passed
@Kamirus Kamirus deleted the kamil/implicit-lib-imports-for-dot-and-implicits-2 branch October 14, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants