Skip to content

Conversation

@altkdf
Copy link
Contributor

@altkdf altkdf commented Jun 23, 2025

No description provided.

@altkdf altkdf changed the title feat: add a Motoko password manager backend feat: CRP-2844 add a Motoko password manager backend Jun 23, 2025
@altkdf altkdf marked this pull request as ready for review June 23, 2025 17:09
@altkdf altkdf requested a review from a team as a code owner June 23, 2025 17:10
@altkdf altkdf changed the title feat: CRP-2844 add a Motoko password manager backend feat: CRP-2844 CRP-2850 add a Motoko password manager backend Jun 25, 2025
@altkdf
Copy link
Contributor Author

altkdf commented Jun 25, 2025

This still requires some restructuring. Currently, we symlink the dfx.json file, but that doens't work with ICP Ninja because it can only serve static assets (not currently possible to replace the link dfx.json. So we probably want to rather have a structure similar to #158, where we create two folders rust and motoko, each with it's own backend and dfx.json, and the symlinked frontend. I will try to do this ASAP.

done

@altkdf
Copy link
Contributor Author

altkdf commented Jun 25, 2025

Side note: some Motoko library changes should not have been part of this PR, but they are not too large and the amount of work that still remains is quite large, so I hope it is okay.

Copy link
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @altkdf!

@altkdf
Copy link
Contributor Author

altkdf commented Jun 26, 2025

@fspreiss I did some quite significant restructuring of this example s.t. it's possible to deploy it to ICP Ninja. The structure is now quite close to the changes to the other examples in the currently open PRs. You would probably want to take another look.

Be aware that the Motoko example currently has some problems. Although we update the ic-vetkeys MOPS package locally and fixed those problems, we still need to release those changes to include them in the example.

@altkdf altkdf changed the title feat: CRP-2844 CRP-2850 add a Motoko password manager backend feat: CRP-2844 CRP-2850 add a Motoko password manager backend and prepare to deploy to ICP Ninja Jun 26, 2025
@altkdf
Copy link
Contributor Author

altkdf commented Jun 26, 2025

@fspreiss can you please try to compile the password manager example? The error in the workflow looks to me like a bug somewhere outside of this repo.

@altkdf
Copy link
Contributor Author

altkdf commented Jun 26, 2025

@altkdf altkdf merged commit 49797c4 into main Jun 27, 2025
31 checks passed
@altkdf altkdf deleted the alex/motoko-password-manager branch June 27, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants