Add test coverage for ladderize function#51
Merged
Conversation
Merged
Co-authored-by: dfornika <145659+dfornika@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Work in progress to address feedback on 'Re root tree' PR
Add test coverage for ladderize function
Feb 20, 2026
dfornika
added a commit
that referenced
this pull request
Feb 20, 2026
* Initial implementation of re-rooting * Remove old use-memo definition * Added ladderization button * Ladderize both ways * reimplement re-rooting on branches * Update src/main/app/components/toolbar.cljs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/main/app/components/tree.cljs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * whitespace * whitespace * Add test coverage for ladderize function (#51) * Initial plan * Add tests for ladderize function Co-authored-by: dfornika <145659+dfornika@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: dfornika <145659+dfornika@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: dfornika <145659+dfornika@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ladderizefunction had no tests despite the codebase having thorough coverage for other tree functions. This adds 8 tests covering the identified gaps.Tests added (
tree_test.cljs)ladderize-ascending-larger-clade-first/ladderize-descending-smaller-clade-first: verify first child tip count ordering for each directionladderize-default-direction-is-ascending: no-arg form equals:ascendingladderize-preserves-tip-count/ladderize-preserves-leaf-names: 25-taxon tree retains all leaves by count and name in both directionsladderize-single-leaf-unchanged: leaf with no children returned as-is;ladderize-idempotent: double-application in same direction is a no-opladderize-newick-round-trip: ladderized tree serializes to Newick and re-parses with identical tip set✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.