Add Group API #457
Merged
Add Group API #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasDorier
force-pushed
the
groupapi
branch
3 times, most recently
from
d45f7eb to
decdf06
Compare
NicolasDorier
force-pushed
the
groupapi
branch
from
decdf06 to
9b63582
Compare
|
Got ACK from Kukks, we can adjust later if we need more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #450
This add a new type of tracked source
GroupTrackedSource.You can create a group and add other tracked sources as children to it.
Any addresses generated by a child will be added automatically to the group.
Removing a children also remove its addresses from the group.
On top of this, I added an API to add addresses directly to a group via
/cryptos/{cryptoCode}/groups/{groupId}/addressesAPI.Some routes for group API need to be accessed through
/cryptosand others directly through/groups.Last, I removed abstraction of tracked-sources in the routes of NBXplorer. This is due to the fact that many routes doesn't make sense for all the tracked-sources. (For example CreatePSBT depends on the ability to be able to generate addresses, which a group doesn't have)