Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support enhanced filtering on interactions query #494

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

jsstevenson
Copy link
Contributor

close #490

Create an interactions query that lets the user constrain the universe of drugs/genes to search for interactions within. Also provides further drug filtering on the usual booleans.

  • In trying to write tests for the latter, I hit an old issue that it seems impossible to make a drug from FactoryBot that has any of the antineoplastic/immunotherapy/approved flags set to true. I was thinking it had to do with the way those flags are initially set when the model instance is created, but this only confused me further. It's written up in Fix drug approval test case #257 , still not sure what the deal is.

@jsstevenson jsstevenson added the priority:medium Medium priority label Apr 24, 2024
Copy link
Contributor

@mcannon068nw mcannon068nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good as is. I can't think of any examples now, but we should keep an eye out for creative/interesting ways to query interaction data going forward that we haven't thought of.

@jsstevenson jsstevenson merged commit 185f899 into dev Apr 26, 2024
3 checks passed
@jsstevenson jsstevenson deleted the interactions-query branch April 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants