Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant code #529

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix: remove redundant code #529

merged 2 commits into from
Oct 22, 2024

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Oct 22, 2024

A little cleanup of unused/redundant stuff -- maybe a merge artifact?

@jsstevenson jsstevenson added priority:low Low priority priority:high High priority and removed priority:low Low priority labels Oct 22, 2024
Copy link
Contributor

@mcannon068nw mcannon068nw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised this made it into the Dev branch. App won't launch with the duplicated code to begin with. Will look out for this more diligently in the future

Copy link
Contributor

@katiestahl katiestahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this didn't fail or get caught by the lint checks for before we merge. Might need to revisit that. I bet this was caused by a merge conflict though

@jsstevenson jsstevenson merged commit e411dc1 into dev Oct 22, 2024
5 checks passed
@jsstevenson jsstevenson deleted the fix-redundant branch October 22, 2024 19:55
@jsstevenson jsstevenson mentioned this pull request Nov 11, 2024
mcannon068nw added a commit that referenced this pull request Dec 6, 2024
* feat: store score components in DB (#518)

* fix: update JAX-CKB URL (#521)

* feat: jax-ckb -> ckb-core (#522)

* fix: chembl version (#524)

* feat: define rake task to generate TSVs (#523)

* fix: remove redundant field (#527)

* build: remove some unused rails boilerplate/imports (#528)

* fix: use declared data version value (#525)

* fix: remove redundant code (#529)

* cicd: update actions revs (#530)

* feat: log graphql requests (#526)

* feat: log API client (#531)

* chore: remove unused readme (#532)

* fix: use docm snapshot data (#533)

* fix: update api uri (#538)

* cicd: add DB check script (#543)

* chore: fix a couple of typos/omissions (#541)

* fix: use latest GO api changes (#542)

* add rows for Download table for 2024 tsvs (#549)

* new row for old Downloads file

* added one more row

---------

Co-authored-by: Cannon <[email protected]>

---------

Co-authored-by: James Stevenson <[email protected]>
Co-authored-by: Cannon <[email protected]>
mcannon068nw added a commit that referenced this pull request Dec 6, 2024
* feat: store score components in DB (#518)

* fix: update JAX-CKB URL (#521)

* feat: jax-ckb -> ckb-core (#522)

* fix: chembl version (#524)

* feat: define rake task to generate TSVs (#523)

* fix: remove redundant field (#527)

* build: remove some unused rails boilerplate/imports (#528)

* fix: use declared data version value (#525)

* fix: remove redundant code (#529)

* cicd: update actions revs (#530)

* feat: log graphql requests (#526)

* feat: log API client (#531)

* chore: remove unused readme (#532)

* fix: use docm snapshot data (#533)

* fix: update api uri (#538)

* cicd: add DB check script (#543)

* chore: fix a couple of typos/omissions (#541)

* fix: use latest GO api changes (#542)

* add rows for Download table for 2024 tsvs (#549)

* new row for old Downloads file

* added one more row

---------

Co-authored-by: Cannon <[email protected]>

---------

Co-authored-by: James Stevenson <[email protected]>
Co-authored-by: Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants