Choose language from a language picker #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to ass some options: supportedLngs This is needed to allow i18next to pick the best match out of all the browser's supported languages list (navigator.languages). Otherwise only the first language in the browwer's list is used, regardless of whether it matches any supported languages or if there are any. Export this to try and make sure that the picker and the i18n config stay in sync. nonExplicitSupportedLngs This is needed to eg. allow fr-BE to be treated as fr. Seems like it's disabled by default because it doesn't play nice with loading translations from external sources.
Maybe over-engineered?
The buttons didn't fit in French
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.