Separate session data per config #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the file name to the session data key, so that we get separate entries per config. This has the effect of auto-switching the grid when choosing a new config - that's not actually an expected use case but it feels correct that the app should only be able to show a consistent set of config and words. Jump through some hoops to avoid not found resulting in junk localstorage entries: Since we fall back to a default list if the name is not recognised (maybe a bad idea?), the param doesn't always match the list filename, and we don't want eg http://localhost:5173/bingo-frontend/foo to result in storing bingoSession-foo in localstorage. Maybe we can skip all that nonsense and do some kind of redirect or not found instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the file name to the session data key, so that we get separate
entries per config.
This has the effect of auto-switching the grid when choosing a new
config - that's not actually an expected use case but it feels correct
that the app should only be able to show a consistent set of config and
words.
Jump through some hoops to avoid not found resulting in junk
localstorage entries:
Since we fall back to a default list if the name is not recognised
(maybe a bad idea?), the param doesn't always match the list filename,
and we don't want eg http://localhost:5173/bingo-frontend/foo to result
in storing bingoSession-foo in localstorage.
Maybe we can skip all that nonsense and do some kind of redirect or not
found instead?