-
Notifications
You must be signed in to change notification settings - Fork 431
fix: iterate on elements #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Ilia Merochkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@mangalaman93 Please do let me know if this PR is sufficient for merged based on your earlier comment here #460 (review). I'm assuming based on the CLAssistant, @ilyatotl will need to sign the CLA, if not I might have to squash his commits. |
|
@SkArchon While I can appreciate the usefulness of a first class iterator, I'm worried about the increase in overall memory usage this PR will introduce. 16 bytes for the Could you not roll-your-own by embedding a Cache inside your own struct? Implement |
Description
This PR is based off of the PR here #460, I have opened a new PR as this only contains a subset of the changes, and I do not have access to push to the original authors fork.
This PR only contains the iteration function, as well as instead of introducing a new type for the
Keyand changing the API, we useany.cc: @ilyatotl, @mangalaman93
Checklist