Skip to content

Build macOS binaries with Travis #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Build macOS binaries with Travis #1105

wants to merge 6 commits into from

Conversation

f-f
Copy link
Member

@f-f f-f commented Jul 13, 2019

Replaces #1101

@Gabriella439
Copy link
Collaborator

Gabriella439 commented Jul 13, 2019

@f-f: Okay, I think I figured out what is going on. Builds that depend on secret tokens can't be triggered from pull requests from forked repositories (otherwise they could exploit the shared secret):

See:

@f-f
Copy link
Member Author

f-f commented Jul 13, 2019

@Gabriel439 but the branch is in this repo?

@Gabriella439
Copy link
Collaborator

@f-f: Oh, weird. Then I'm not sure. For reference, Travis did trigger on another pull request that I pushed. I'm still trying to figure out why it doesn't trigger on yours

@Gabriella439
Copy link
Collaborator

It seems to only trigger on my branches and pull requests, like this one I opened:

#1107

Maybe it's because the token belongs to me?

@f-f
Copy link
Member Author

f-f commented Jul 13, 2019

@Gabriel439 I think that's unlikely. We have the same setup in Spago (with private token and everything) and it triggers on every PR by anyone

@Gabriella439
Copy link
Collaborator

@f-f: I added you as an admin for this repository so you should be able to manage the Travis settings yourself now. Check them out and see if anything looks out of the ordinary

@f-f
Copy link
Member Author

f-f commented Jul 13, 2019

@Gabriel439 thanks! I was wondering if it could be because we are still on travis-ci.org but everything should move to travis-ci.com

@f-f
Copy link
Member Author

f-f commented Jul 13, 2019

Update: found it, apparently Travis cannot parse the yml file and silently fails

@f-f
Copy link
Member Author

f-f commented Jul 13, 2019

Closing this one and reopening #1101, sorry for the noise

@f-f f-f closed this Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants