-
Notifications
You must be signed in to change notification settings - Fork 218
Build macOS binaries with Travis #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Hardy Jones <[email protected]>
Co-Authored-By: Hardy Jones <[email protected]>
Co-Authored-By: Hardy Jones <[email protected]>
@f-f: Okay, I think I figured out what is going on. Builds that depend on secret tokens can't be triggered from pull requests from forked repositories (otherwise they could exploit the shared secret): See: |
@Gabriel439 but the branch is in this repo? |
@f-f: Oh, weird. Then I'm not sure. For reference, Travis did trigger on another pull request that I pushed. I'm still trying to figure out why it doesn't trigger on yours |
It seems to only trigger on my branches and pull requests, like this one I opened: Maybe it's because the token belongs to me? |
@Gabriel439 I think that's unlikely. We have the same setup in Spago (with private token and everything) and it triggers on every PR by anyone |
@f-f: I added you as an admin for this repository so you should be able to manage the Travis settings yourself now. Check them out and see if anything looks out of the ordinary |
@Gabriel439 thanks! I was wondering if it could be because we are still on |
Update: found it, apparently Travis cannot parse the yml file and silently fails |
Closing this one and reopening #1101, sorry for the noise |
Replaces #1101