Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean up use date picker #76

Closed
wants to merge 3 commits into from

Conversation

flaminic
Copy link
Contributor

@flaminic flaminic commented Oct 2, 2024

Refactoring useDatePicker:

  • Remove isValid, errorMessage, and warningMessage as we are using validateDateString directly.
  • Remove calendarDate as well, since we don't want to expose it anymore

@flaminic flaminic requested a review from kabaros October 2, 2024 17:58
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (6770573) to head (371a08f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/helpers.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   91.25%   91.32%   +0.06%     
==========================================
  Files          56       56              
  Lines        1201     1199       -2     
  Branches      326      328       +2     
==========================================
- Hits         1096     1095       -1     
+ Misses        103      102       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flaminic flaminic changed the title feat: clean up use date picker #75 feat: clean up use date picker Oct 2, 2024
@flaminic flaminic changed the title feat: clean up use date picker feat: clean up use date picker Oct 2, 2024
@flaminic flaminic closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants