Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #285

Closed
wants to merge 1 commit into from
Closed

PHP 8.4 #285

wants to merge 1 commit into from

Conversation

gnutix
Copy link
Contributor

@gnutix gnutix commented Jan 10, 2025

I get a failing test locally, not sure if it might be environment-dependant, as it relates to MX validation. So I skipped GrumPHP to be able to commit.

1) Zend_Validate_EmailAddressTest::testIdnHostnameInEmaillAddress
Failed asserting that false is true.

tests/Zend/Validate/EmailAddressTest.php:612

Also, composer-require-checker seems to have some trouble. Maybe related to the VCS repo I had to setup to point zf1-validate to my fork ?

ComposerRequireChecker 3.8.0@537138b833ab0f9ad72b667a72bece2a765e88ab

PHP Fatal error:  Uncaught Error: Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of '512' frames in vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/DefinedSymbolCollector.php:55

Comment on lines +24 to +29
"repositories": [
{
"type": "vcs",
"url": "https://github.com/tipee-sa/zendframework1-filter"
}
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be reverted.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.77%. Comparing base (065a544) to head (901e1d2).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #285      +/-   ##
============================================
- Coverage     32.24%   31.77%   -0.47%     
  Complexity      804      804              
============================================
  Files            45       45              
  Lines          7772     7732      -40     
============================================
- Hits           2506     2457      -49     
- Misses         5266     5275       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaydiablo
Copy link
Member

Added in #286, thanks!

@jaydiablo jaydiablo closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants