Skip to content

Conversation

@DymoneLewis
Copy link
Collaborator

改动点晚点补充

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

⚠️ No Changeset found

Latest commit: d41c360

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DymoneLewis DymoneLewis closed this Dec 1, 2025
Copilot finished reviewing on behalf of DymoneLewis December 1, 2025 11:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements comprehensive UI style optimization for the LogicFlow library, focusing on modernizing the visual appearance with refined spacing, rounded corners, improved shadows, and enhanced grid rendering capabilities.

Key Changes

  • Enhanced control panel and menu styling with updated padding, border-radius, and theme mode support
  • Implemented advanced grid rendering with configurable bold lines and dynamic dash patterns
  • Added universal rounded corner generation for shapes and polylines
  • Refactored theme system for better organization and maintainability

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/extension/src/style/raw.ts Updated control, menu, DnD, and mini-map styling with modern design tokens
packages/extension/src/style/index.less LESS version of the same styling updates with theme mode support
packages/extension/src/components/control/index.ts Added hideText property and theme mode integration for control items
packages/core/src/view/shape/Polygon.tsx Fixed className typo and refactored to use generateRoundedCorners utility
packages/core/src/view/overlay/gridConfig.ts New configuration system for advanced grid rendering with bold lines
packages/core/src/view/overlay/OutlineOverlay.tsx Refactored with common rendering function to reduce duplication
packages/core/src/view/overlay/Grid.tsx Major enhancement with mesh edge rendering, bold line patterns, and dynamic dash arrays
packages/core/src/view/node/HtmlNode.tsx Added shadow filter support for HTML nodes
packages/core/src/view/edge/PolylineEdge.tsx Integrated rounded corner generation for polyline edges
packages/core/src/view/Control.tsx Adjusted resize control sizing for better visual alignment
packages/core/src/util/theme.ts Refactored to use centralized theme constants
packages/core/src/util/geometry.ts Added comprehensive rounded corner generation utility
packages/core/src/util/edge.ts Added heightOffset parameter for flexible bounding box calculation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* - baseSize 保证为正数
*/
export function validateGridConfig(cfg: MajorBoldConfig): MajorBoldConfig {
console.log('validateGridConfig', cfg)
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debug console.log statement before merging to production. This appears to be leftover debugging code that should be removed.

Suggested change
console.log('validateGridConfig', cfg)

Copilot uses AI. Check for mistakes.
TRANSLATE_Y,
].join(',')
const transform = `matrix(${matrixString})`
const radius = Math.min(Math.max(2, config.thickness ?? 1), size / 4)
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable 'radius' is declared but never used in the render method. Consider removing it or documenting why it's needed for future use.

Suggested change
const radius = Math.min(Math.max(2, config.thickness ?? 1), size / 4)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants