Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive layout #13

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: responsive layout #13

wants to merge 19 commits into from

Conversation

alysonmota
Copy link

add responsive layout for mobile

@vercel
Copy link

vercel bot commented Feb 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
fala-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 1:27AM (UTC)

@diego3g
Copy link
Owner

diego3g commented Feb 19, 2023

That's great! I'll leave my comments until the next couple of days.

@diego3g diego3g self-requested a review February 19, 2023 12:40
Copy link
Owner

@diego3g diego3g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

  1. The copy to clipboard button could be hidden on mobile I think or positioned on the bottom side of the editor because today it's above the code.

image

  1. The code is overriding the footer:

image

  1. The social button menu is not working properly (it's somehow under the sidebar I think). Also, if you click twice on this menu it looks like it's not closing, at least here, it opens but I can't close it anymore.

image

@vercel
Copy link

vercel bot commented Feb 25, 2023

@alysonmota is attempting to deploy a commit to the Rocketseat Team on Vercel.

A member of the Team first needs to authorize it.

@diego3g
Copy link
Owner

diego3g commented Feb 26, 2023

We are getting near to a perfect implementation!

Some other points:

  • Can the file explorer be open as default on larger screens?
  • If I click very close to the menu here, on the very right, it does not close the menu, it links to one of the social links.

image

@alysonmota
Copy link
Author

Can the file explorer be open as default on larger screens?

Yes, I also think it doesn't make sense for the explorer to start closed on larger screens

If I click very close to the menu here, on the very right, it does not close the menu, it links to one of the social links.

I also noticed this issue, but only in DevTools. On my device, it appeared normally. I'll take a look into this.

@vercel
Copy link

vercel bot commented Feb 26, 2023

Deployment failed with the following error:

Tried to attach Edge Config ecfg_57gaz0taa0s18m6fvjeosvmfswfa, but it does not exist. Remove or update the EDGE_CONFIG environment variable and try again.

Learn More: https://vercel.com/docs/errors#error-list/invalid-edge-config-connection-string

@diego3g diego3g self-requested a review February 27, 2023 12:36
Copy link
Owner

@diego3g diego3g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just some points:

  1. The "Copy to clipboard" button is misplaced on large viewport:

CleanShot 2023-02-27 at 09 46 38@2x

  1. We should not have cursor-pointer on all menu items, only the clickable ones. As we are using slot, we could add the cursor-pointer only on buttons;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants