-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: responsive layout #13
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
That's great! I'll leave my comments until the next couple of days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
- The copy to clipboard button could be hidden on mobile I think or positioned on the bottom side of the editor because today it's above the code.
- The code is overriding the footer:
- The social button menu is not working properly (it's somehow under the sidebar I think). Also, if you click twice on this menu it looks like it's not closing, at least here, it opens but I can't close it anymore.
Co-authored-by: Diego Fernandes <[email protected]>
@alysonmota is attempting to deploy a commit to the Rocketseat Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: Diego Fernandes <[email protected]>
Yes, I also think it doesn't make sense for the explorer to start closed on larger screens
I also noticed this issue, but only in DevTools. On my device, it appeared normally. I'll take a look into this. |
Deployment failed with the following error:
Learn More: https://vercel.com/docs/errors#error-list/invalid-edge-config-connection-string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add responsive layout for mobile