Skip to content

Update Dockerfile#7721

Closed
HAjAdnan wants to merge 1 commit into
diegosouzapw:release/v3.8.49from
HAjAdnan:patch-1
Closed

Update Dockerfile#7721
HAjAdnan wants to merge 1 commit into
diegosouzapw:release/v3.8.49from
HAjAdnan:patch-1

Conversation

@HAjAdnan

Copy link
Copy Markdown

Summary

  • Describe the user-facing or operational change.

Related Issues

  • Closes #
  • Related to #

Validation

  • npm run lint
  • npm run test:unit
  • npm run test:coverage
  • Coverage is still >= 60% for statements, lines, functions, and branches
  • SonarQube PR analysis is green or any remaining issues are explicitly documented below

Tests Added Or Updated

  • List every changed or added automated test file.
  • If no production code changed, state that here.

Coverage Notes

  • If this PR changes src/, open-sse/, electron/, or bin/, explain which tests cover the change.
  • If coverage moved down in any touched file, explain why and what follow-up task will recover it.

Reviewer Notes

  • Call out any risky areas, migrations, feature flags, or manual validation that reviewers should know about.

@HAjAdnan
HAjAdnan requested a review from diegosouzapw as a code owner July 19, 2026 05:29
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@diegosouzapw

Copy link
Copy Markdown
Owner

Thanks again for the Dockerfile attention — really appreciate you looking at the build. 🙏

Closing this one for the same reason as your #7723 (and noting the two overlap on the same file): it strips id=apt-cache from the BuildKit cache mounts. Those id= arguments were added on purpose in #6291 to fix a parse failure on strict BuildKit frontends like Railway's Metal builder, which reject cache mounts without an explicit id=. Removing them (even partially — this PR leaves id=apt-lists but drops id=apt-cache on the same RUN) re-triggers exactly the shape that strict frontend rejects. Regular docker buildx won't complain locally, so it's an easy one to miss.

Nothing from your diff is being used — closing here just means the current mounts are intentional.

If there's a concrete build issue you ran into, please open an issue with the exact error/builder and we'll sort the real cause. Thank you for contributing — hope to see more from you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants