Skip to content

Build on the latest nightly again#58

Merged
mfpiccolo merged 2 commits intodiesel-rs:masterfrom
mcasper:build_on_latest_nightly
Dec 9, 2015
Merged

Build on the latest nightly again#58
mfpiccolo merged 2 commits intodiesel-rs:masterfrom
mcasper:build_on_latest_nightly

Conversation

@mcasper
Copy link
Contributor

@mcasper mcasper commented Dec 9, 2015

Updates various dependencies affected by
rust-lang/rust#29850.

Opening so that other people won't have to duplicate this work, once
https://github.com/slapresta/rust-dotenv/pull/27 is merged I'll update
the dependency and this can go in.

Updates various dependencies affected by
rust-lang/rust#29850.

Opening so that other people won't have to duplicate this work, once
https://github.com/slapresta/rust-dotenv/pull/27 is merged I'll update
the dependency and this can go in.
@mfpiccolo
Copy link
Contributor

@mcasper Nicely done. I was just looking into this and saw your PR here and at rust-dotenv.

@mfpiccolo
Copy link
Contributor

Looks good but we have to change travis config

@mcasper
Copy link
Contributor Author

mcasper commented Dec 9, 2015

Was about to ask about that. Just remove the nightly-2015-12-03 entry, or update to today?

@mfpiccolo
Copy link
Contributor

I was thinking just remove it but I am not sure if we have to revert the other config Sean added

@mcasper
Copy link
Contributor Author

mcasper commented Dec 9, 2015

I'm assuming allowing failures on nightly is to try and get a glimpse of future breakages, so let's see what happens if we bump the date stamped version.

@mcasper
Copy link
Contributor Author

mcasper commented Dec 9, 2015

Looks like that did the trick!

@mfpiccolo
Copy link
Contributor

🎉

mfpiccolo added a commit that referenced this pull request Dec 9, 2015
@mfpiccolo mfpiccolo merged commit b8b42ea into diesel-rs:master Dec 9, 2015
@mcasper mcasper deleted the build_on_latest_nightly branch December 9, 2015 04:14
@mfpiccolo
Copy link
Contributor

Thank you! I was just looking into this here and at dotenv when I saw your PRs come in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants