-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TG-7618] Fix precision parsing in string_format #4649
base: develop
Are you sure you want to change the base?
[TG-7618] Fix precision parsing in string_format #4649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 9c7b44a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/111548705
Would it be possible to include a test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds believable but a "fails before but works now" test case, either system or unit, would be good.
The 4th group in the regular expression matches `(\.\d+)?` so the dot should be ignored before the string can be parsed to an int.
This checks that having a format flag with precision defined doesn't crash the solver.
9c7b44a
to
efc59fd
Compare
I started adding a test but it will require a model for Float in java-models-library |
The 4th group in the regular expression matches
(\.\d+)?
so the dotshould be ignored before the string can be parsed to an int.