Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce code_havoc_objectt #4756

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

introduce code_havoc_objectt #4756

wants to merge 1 commit into from

Conversation

kroening
Copy link
Member

@kroening kroening commented Jun 6, 2019

This documents an existing codet variant.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@@ -2380,6 +2380,59 @@ inline code_try_catcht &to_code_try_catch(codet &code)
return ret;
}

/// \ref codet representation of a 'havoc_object' statement.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please refrain from recursive documentation? No B. means B., please. If there genuinely is documentation of said statement then refer to it, else here will need to be the place to document it, I'm afraid.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 747c619).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114571039

This documents an existing codet variant.
@kroening kroening force-pushed the code_havoc_object branch from 747c619 to 24b488f Compare August 4, 2019 15:13
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 24b488f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/121880661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants