-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch goto-analyzer reachable-functions json and xml output. #4947
base: develop
Are you sure you want to change the base?
Patch goto-analyzer reachable-functions json and xml output. #4947
Conversation
Source locations occassionally omit a line number, and printing an empty string in the json and xml output renders the output unparsable. This patch uses "0" in place of the empty string in the output.
@markrtuttle and I will co-ordinate whether to go ahead with this one or with #4879, which largely fix the same problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 3f79983).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/120770347
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
Codecov Report
@@ Coverage Diff @@
## develop #4947 +/- ##
===========================================
- Coverage 69.26% 69.26% -0.01%
===========================================
Files 1307 1307
Lines 108102 108093 -9
===========================================
- Hits 74881 74870 -11
- Misses 33221 33223 +2
Continue to review full report at Codecov.
|
@markrtuttle I'm biased, but do prefer my patch in #4879 as it factors out some of the logic to avoid code repetition. |
Source locations occassionally omit a line number, and printing
an empty string in the json and xml output renders the output
unparsable. This patch uses "0" in place of the empty string
in the output.