Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch goto-analyzer reachable-functions json and xml output. #4947

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

markrtuttle
Copy link
Collaborator

Source locations occassionally omit a line number, and printing
an empty string in the json and xml output renders the output
unparsable. This patch uses "0" in place of the empty string
in the output.

  • [ x] Each commit message has a non-empty body, explaining why the change was made.
  • [ x] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [ x] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • [ x] My PR is restricted to a single feature or bugfix.
  • [ x] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Source locations occassionally omit a line number, and printing
an empty string in the json and xml output renders the output
unparsable.  This patch uses "0" in place of the empty string
in the output.
@tautschnig
Copy link
Collaborator

@markrtuttle and I will co-ordinate whether to go ahead with this one or with #4879, which largely fix the same problem.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 3f79983).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/120770347
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@codecov-io
Copy link

Codecov Report

Merging #4947 into develop will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4947      +/-   ##
===========================================
- Coverage    69.26%   69.26%   -0.01%     
===========================================
  Files         1307     1307              
  Lines       108102   108093       -9     
===========================================
- Hits         74881    74870      -11     
- Misses       33221    33223       +2
Impacted Files Coverage Δ
src/goto-analyzer/unreachable_instructions.cpp 84.61% <60%> (-1%) ⬇️
src/util/ssa_expr.cpp 87.5% <0%> (-0.31%) ⬇️
unit/util/ssa_expr.cpp 100% <0%> (ø) ⬆️
src/util/ssa_expr.h 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad2a27...3f79983. Read the comment docs.

@tautschnig
Copy link
Collaborator

@markrtuttle I'm biased, but do prefer my patch in #4879 as it factors out some of the logic to avoid code repetition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants