Skip to content

Dominator nodes only store immediate dominator #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Dominator nodes only store immediate dominator #5137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2c1a12
CFG dominator algorithm change to more closely resemble Coopers
JohnDumbell Oct 9, 2019
533c35a
Update API calls
JohnDumbell Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions jbmc/src/java_bytecode/java_local_variable_table.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,10 +464,7 @@ static java_bytecode_convert_methodt::method_offsett get_common_dominator(
candidate_dominators;
for(auto v : merge_vars)
{
const auto &dominator_nodeidx=
dominator_analysis.cfg.entry_map.at(v->var.start_pc);
const auto &this_var_doms=
dominator_analysis.cfg[dominator_nodeidx].dominators;
const auto &this_var_doms = dominator_analysis.dominators(v->var.start_pc);
for(const auto this_var_dom : this_var_doms)
if(this_var_dom<=first_pc)
candidate_dominators.push_back(this_var_dom);
Expand Down
Loading