Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen_nondet_array_init: arrays may have size 0 #5342

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

gen_nondet_array_init: arrays may have size 0 #5342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a47ec0c
gen_nondet_array_init: arrays may have size 0
May 13, 2020
2f2c1fd
use mp_integer instead of size_t
May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ansi-c/c_nondet_symbol_factory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@ void symbol_factoryt::gen_nondet_array_init(
auto const &array_type = to_array_type(expr.type());
const auto &size = array_type.size();
PRECONDITION(size.id() == ID_constant);
auto const array_size = numeric_cast_v<size_t>(to_constant_expr(size));
DATA_INVARIANT(array_size > 0, "Arrays should have positive size");
for(size_t index = 0; index < array_size; ++index)
auto const array_size = numeric_cast_v<mp_integer>(to_constant_expr(size));
DATA_INVARIANT(array_size >= 0, "Arrays must have non-negative size");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please have a test that covers the case of size 0?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note to perhaps help make progress on this one: I believe #4928 has such a test.

for(mp_integer index = 0; index < array_size; ++index)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this makes sense in spirit, does this actually make a difference in practice (other than slightly worse performance)? We wouldn't be able to allocate memory for an object larger than max(size_t) anyway.

{
gen_nondet_init(
assignments,
Expand Down