-
Notifications
You must be signed in to change notification settings - Fork 273
Handle infinity in the back-end and in the simplifier #6914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6914 +/- ##
========================================
Coverage 77.78% 77.79%
========================================
Files 1568 1568
Lines 180269 180309 +40
========================================
+ Hits 140230 140263 +33
- Misses 40039 40046 +7 ☔ View full report in Codecov by Sentry. |
937751c
to
0bd752b
Compare
0bd752b
to
1fe3e99
Compare
We need to support at least object_size operations over infinity in the back-end as the postponed evaluation iterates over all objects, which may include ones that have infinite size.
1fe3e99
to
08b12ec
Compare
size_expr->id() == ID_infinity && | ||
can_cast_type<integer_bitvector_typet>(object_size.type())) | ||
{ | ||
object_size = to_integer_bitvector_type(postponed_object_size->type()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the actual size of infinity still bounded by the maximum offset size in the current pointer encoding?
Closing in favour of #8469. |
We need to support at least object_size operations over infinity in the
back-end as the postponed evaluation iterates over all objects, which
may include ones that have infinite size.