Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate source_locationt::get/set_function #7239

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

kroening
Copy link
Member

Following #2149, this deprecates source_locationt::get/set_function; the reason is given as a comment.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Following #2149, this deprecates source_locationt::get/set_function; the
reason is given as a comment.
@tautschnig
Copy link
Collaborator

Well, yes, I'm all for it, but then we need to make progress on #3514 to demonstrate that this removal is actually doable.

@tautschnig
Copy link
Collaborator

Well, yes, I'm all for it, but then we need to make progress on #3514 to demonstrate that this removal is actually doable.

Which, in turn, means that we need to revive #4131 and get clarity on that.

@tautschnig tautschnig removed their assignment Oct 13, 2022
@kroening
Copy link
Member Author

I am aware; this PR is to be seen as deterrent for new usage.

@tautschnig
Copy link
Collaborator

I am aware; this PR is to be seen as deterrent for new usage.

I can see that this might work for get_function(), but usage of set_function() may be required because of other, existing functionality (such as labelling properties).

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 77.99% // Head: 77.99% // No change to project coverage 👍

Coverage data is based on head (99ce20c) compared to base (9baef8f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7239   +/-   ##
========================================
  Coverage    77.99%   77.99%           
========================================
  Files         1619     1619           
  Lines       187184   187184           
========================================
  Hits        145999   145999           
  Misses       41185    41185           
Impacted Files Coverage Δ
src/util/source_location.h 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kroening kroening marked this pull request as ready for review October 13, 2022 13:15
@kroening kroening merged commit 05f2905 into develop Oct 13, 2022
@kroening kroening deleted the deprecate_source_location_function_name branch October 13, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants