Skip to content

Minor formatting fix to contracts help #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

zhassan-aws
Copy link
Collaborator

@zhassan-aws zhassan-aws commented Feb 23, 2023

Minor formatting fixes to the contracts section of goto-instrument --help. Primarily added missing newlines without which the --apply-loop-contracts option was appearing with the previous option. This is the output diff:

242c242
<                              force the aggressive slicer to preserve function <f>
---
>                               force the aggressive slicer to preserve function <f>
246c246
<                              force aggressive slicer to preserve all direct paths
---
>                               force aggressive slicer to preserve all direct paths
249,250c249,252
< --dfcc <harness>   activate dynamic frame condition checking for function
<                    contracts using the given harness as entry point --apply-loop-contracts
---
>  --dfcc <harness>             activate dynamic frame condition checking
>                               for function contracts using the given
>                               harness as entry point
>  --apply-loop-contracts
  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@feliperodri feliperodri added cleanup aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 78.43% // Head: 78.50% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (e663f8a) compared to base (d7099ae).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7563      +/-   ##
===========================================
+ Coverage    78.43%   78.50%   +0.06%     
===========================================
  Files         1670     1670              
  Lines       191671   191671              
===========================================
+ Hits        150331   150462     +131     
+ Misses       41340    41209     -131     
Impacted Files Coverage Δ
.../goto-instrument/goto_instrument_parse_options.cpp 71.63% <ø> (ø)
src/util/bitvector_expr.h 97.41% <0.00%> (+0.46%) ⬆️
src/util/symbol_table.cpp 91.30% <0.00%> (+2.17%) ⬆️
src/util/type.h 98.68% <0.00%> (+7.89%) ⬆️
src/util/validate_helpers.h 100.00% <0.00%> (+11.11%) ⬆️
src/big-int/bigint.cc 89.00% <0.00%> (+14.26%) ⬆️
src/util/validate_expressions.cpp 93.75% <0.00%> (+15.62%) ⬆️
src/util/string_hash.cpp 45.45% <0.00%> (+18.18%) ⬆️
src/util/validate_types.cpp 93.33% <0.00%> (+56.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit 3ee2b3a into diffblue:develop Feb 27, 2023
@zhassan-aws zhassan-aws deleted the fix-contracts-help branch February 28, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users cleanup Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants