-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] Move parse_options.cpp
and cmdline.cpp
under src/cli_utils/
.
#7784
Conversation
We want to start breaking down the `src/util/` folder in a manner that makes its constituents more organised in a logical hierarchy and also to allow us to set up better boundaries between different modules (and allow the build system to evolve in a way that allows more selective inclusion of different components in a library built).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7784 +/- ##
========================================
Coverage 78.58% 78.58%
========================================
Files 1693 1693
Lines 193381 193381
========================================
Hits 151962 151962
Misses 41419 41419 ☔ View full report in Codecov by Sentry. |
I'm afraid that we'll end up with a very large number of folders right under |
As a further note: can we take a first small step and move |
@esteffin Can you explain the build-system related concerns you had about that? I guess the way |
@tautschnig However the extent of the work mean that the split will happen in a number of separate PR with the outcome of having an unstabilized To avoid an organic split, that can affect the final outcome, we decided to open an RFC (soon to be created) where the fate of I will leave this PR open and reference it in the RFC, but it will be unlikely progressing until a more consensual decision on the structure of |
Similar to #8110 , I don't see having the time to see this through any time soon, therefore I will close this PR in an attempt to keep the repository tidy. If anyone wants to work on this one and get it merged, feel free to re-open this PR, or to use the branch as a basis for a separate PR. Thanks for your understanding. |
We want to start breaking down the
src/util/
folder in a manner that makes its constituents more organised in a logical hierarchy and also to allow us to set up better boundaries between different modules (and allow the build system to evolve in a way that allows more selective inclusion of different components in a library built).There's still work to be done here (we expect the
Make
builds to fail as we haven't ported the make built to the new hierarchy yet), but we want to make sure that the community aligns with our aims and process here before we commit to more (tedious) work.